Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "RNTester-ios / RCTAppDelegate > correctly check for USE_HERMES Flag" #41622

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Revert "RNTester-ios / RCTAppDelegate > correctly check for USE_HERMES Flag" #41622

merged 1 commit into from
Nov 24, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Nov 23, 2023 •
edited
Loading

Summary:

In the codebase, we never set the RCT_USE_HERMES flag.

When we install the pods, we use the USE_HERMES flag and we set USE_HERMES as a build setting. So, the RCT_USE_HERMES flag will always be not set for the OSS.

Screenshot 2023-11-23 at 12 18 08

Changelog:

[iOS][Fixed] - Use the right USE_HERMES flag

Test Plan:

Revert Hammer

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 23, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable November 23, 2023 12:14
@analysis-bot
Copy link

analysis-bot commented Nov 23, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,518,640 -9,151,995
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,756,752 -11,297,089
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 67c852e
Branch: main

@huntie huntie merged commit 9dfb0ff into 0.73-stable Nov 24, 2023
63 checks passed
@cortinico cortinico deleted the cipolleschi/revert-use_hermes branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cipolleschi @analysis-bot @huntie @facebook-github-bot